Fix compliance findings in Frends.JSON.Validate (net8, analyzers, error handling) - #44
Merged
Merged
Conversation
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.JSON.Validate
Fix compliance findings in Frends.JSON.Validate (net8, analyzers, error handling)
Aug 5, 2026
| @@ -10,4 +13,20 @@ public class Options | |||
| /// </summary> | |||
| /// <example>true</example> | |||
| public bool ThrowOnInvalidJson { get; set; } | |||
Contributor
There was a problem hiding this comment.
@copilot rename ThrowOnInvalidJson to FailOnInvalidJson everywhere (option property, XML docs, usages in code). The reason is that ThrowErrorOnFailure now decides whether to throw or return Success=false, so the old name was misleading - FailOnInvalidJson only controls whether invalid JSON is treated as an error at all.
his is a breaking change due to renamed option, so bump version to 2.0.0
Contributor
Author
There was a problem hiding this comment.
Done. Renamed ThrowOnInvalidJson to FailOnInvalidJson in Options.cs, Validate.cs, and all test files, and bumped the version to 2.0.0. The CHANGELOG documents this as a breaking change. Commit: Rename ThrowOnInvalidJson to FailOnInvalidJson, bump version to 2.0.0.
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
…ency" This reverts commit 980fb5b. Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
MichalFrends1
marked this pull request as ready for review
August 13, 2026 06:03
MatteoDelOmbra
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 5 Frends Task analyzer findings and upgrades the task to .NET 8, adding standard error-handling options in the process.
Changes
Compliance fixes
JSONclass madestatic(FT0004)CancellationTokenparameter added toValidate()(FT0007)Errorproperty added toResult(FT0011)ThrowErrorOnFailureandErrorMessageOnFailureadded toOptions(FT0015 ×2)Infrastructure
net6.0→net8.01.0.0→1.1.0Error handling
Added
Helpers/ErrorHandler.cs(standard pattern).Validate()now wraps all logic in a top-level try/catch:The existing
ThrowOnInvalidJsonbehaviour is preserved inside the inner try/catch.Tests
CancellationToken.NoneErrorHandlerTests.csadded covering throw-on-failure, return-failed-result, and custom error message scenarios